flyrain commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1980741611
##########
spec/polaris-management-service.yml:
##########
@@ -905,6 +907,51 @@ components:
required:
- roleArn
+ S3CompatibleStorageConfigInfo:
+ type: object
+ description: S3 compatible storage configuration info (MinIO, Ceph, Dell
ECS, Netapp StorageGRID, ...)
+ allOf:
+ - $ref: '#/components/schemas/StorageConfigInfo'
+ properties:
+ s3.endpoint:
+ type: string
+ description: the S3 endpoint, will also be used as STS endpoint
+ example: "http[s]://host:port"
+ s3.credentials.catalog.accessKeyId:
+ type: string
+ description: Default to AWS credentials, otherwise set the
environement variable name for the 'ACCESS_KEY_ID' used by the catalog to
communicate with S3
+ example: "CATALOG_1_ACCESS_KEY_ENV_VARIABLE_NAME or
AWS_ACCESS_KEY_ID"
Review Comment:
> Otherwise the creator let the key parameters empty, "cross fingers", and
let default s3 sdk use whatever is available in polaris service environement.
The server side can have a configurable map of `(s3 endpoint,
(accessKeyEnvVar, secretAccessKeyEnvVar))`. In that case, clients don't have to
provide these parameters, at the same time, Polaris server can always find the
correct env variables per the key(s3 endpoint). WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
