lefebsy commented on PR #389: URL: https://github.com/apache/polaris/pull/389#issuecomment-2708233405
> Thanks a lot for working on it. Getting close. Left some comments. Other than the server side env variable settings, can we also have unit tests for two new classes added? Is it ok for you if I do UT only for config class and move to dockerized tests for credentials class ? I am really not good in the mock area. I can easily add minio to regtests docker-compose and enrich regtests/t_spark_sql My first try just learned me not to name script with "S3" inside otherwise it's trapped by AWS stop pattern and never run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
