flyrain commented on PR #389: URL: https://github.com/apache/polaris/pull/389#issuecomment-2708621197
> Is it ok for you if I do UT only for config class and move to dockerized tests for credentials class ? I am really not good in the mock code area. > > I can easily add minio to regtests docker-compose and enrich "regtests/t_spark_sql/" > > My first try just learned me not to name script with "S3" inside otherwise it's trapped by AWS stop pattern and never run. I'm OK with a followup PR to resolve the mock related unit tests. We can get some help from the community. Can you file an issue to track that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
