dimas-b commented on code in PR #1112: URL: https://github.com/apache/polaris/pull/1112#discussion_r1981560621
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java: ########## @@ -285,7 +285,11 @@ DropEntityResult dropEntityIfExists( * @param entityId the id of the entity to load */ @Nonnull - EntityResult loadEntity(@Nonnull PolarisCallContext callCtx, long entityCatalogId, long entityId); + EntityResult loadEntity( + @Nonnull PolarisCallContext callCtx, + long entityCatalogId, + long entityId, + @Nonnull PolarisEntityType entityType); Review Comment: At this point it is a required parameter for the incoming NoSQL implementation. Is that acceptable, @dennishuo ? If yes, I'll update the javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org