dimas-b commented on code in PR #1112:
URL: https://github.com/apache/polaris/pull/1112#discussion_r1981585838


##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##########
@@ -351,7 +351,7 @@ public void deleteAll(@Nonnull PolarisCallContext callCtx) {
   /** {@inheritDoc} */
   @Override
   public @Nullable PolarisBaseEntity lookupEntity(
-      @Nonnull PolarisCallContext callCtx, long catalogId, long entityId) {
+      @Nonnull PolarisCallContext callCtx, long catalogId, long entityId, int 
typeCode) {

Review Comment:
   this is not a hint though, it is a require input for finding right index for 
lookup (current POC, which is not published yet)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to