adutra commented on code in PR #1112:
URL: https://github.com/apache/polaris/pull/1112#discussion_r1983710700
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -327,7 +331,10 @@ ChangeTrackingResult loadEntitiesChangeTracking(
*/
@Nonnull
ResolvedEntityResult loadResolvedEntityById(
- @Nonnull PolarisCallContext callCtx, long entityCatalogId, long
entityId);
+ @Nonnull PolarisCallContext callCtx,
+ long entityCatalogId,
+ long entityId,
+ PolarisEntityType entityType);
Review Comment:
We need to open a discuss thread about default nullability assumptions in
polaris. I was asked to do so a while ago but forgot completely 😬
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
