lefebsy commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1989454133


##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -250,6 +268,21 @@ public Builder setStorageConfigurationInfo(
             awsConfig.validateArn(awsConfigModel.getRoleArn());
             config = awsConfig;
             break;
+
+          case S3_COMPATIBLE:

Review Comment:
   Correct.
   
   To complete the response given to @dimas-b a few lines higher :
   
   Before the security arbitrage favoring vending only STS there were more 
options to be used by onPrem ecosystems habits (keys that do not expire quickly 
by exemple).
   
   Since then, the difference between the AWS class and the S3compatible class 
is smaller.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to