eric-maynard commented on code in PR #1147:
URL: https://github.com/apache/polaris/pull/1147#discussion_r1992146705
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEntityType.java:
##########
@@ -32,9 +32,10 @@ public enum PolarisEntityType {
CATALOG_ROLE(5, CATALOG, true, false),
NAMESPACE(6, CATALOG, false, true),
// generic table is either a view or a real table
- TABLE_LIKE(7, NAMESPACE, false, false),
+ ICEBERG_TABLE_LIKE(7, NAMESPACE, false, false),
TASK(8, ROOT, false, false),
- FILE(9, TABLE_LIKE, false, false);
+ FILE(9, ICEBERG_TABLE_LIKE, false, false),
+ GENERIC_TABLE(10, NAMESPACE, false, false);
Review Comment:
@dennishuo / @dimas-b do either of you have a POV on adding a new entity
type here rather than a subtype of TABLE_LIKE?
One one hand, generic tables conceptually are "table-like". But
TableLikeEntity currently includes a "location" and many places in the code
that handle it seem to assume it's an Iceberg entity. I want to try to avoid
any confusion or accidental mixing of the types, so I decided to create a
standalone entity and to rename the TableLikeEntity for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
