eric-maynard commented on code in PR #1147: URL: https://github.com/apache/polaris/pull/1147#discussion_r1994774400
########## polaris-core/src/main/java/org/apache/polaris/core/entity/GenericTableEntity.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.entity; + +import com.fasterxml.jackson.annotation.JsonIgnore; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.rest.RESTUtil; + +/** + * A {@link PolarisEntity} implementation for generic tables. These tables are not Iceberg-like in + * that they may not have a schema or base location. Similarly to {@link IcebergTableLikeEntity} + * however, these tables have an identifier and a parent namespace. + */ +public class GenericTableEntity extends PolarisEntity { Review Comment: We did have a consensus there (and another PR has merged that bears this name) but personally I am not opposed to a change if we find a better alternative. "Generic" was my suggestion however, so I will say a few things in defense of it: 1. I actually think Iceberg tables _can_ be a subtype of generic table. Currently generic tables are always untyped but in the future I believe we may want to do some kind of validation (e.g. "delta" format tables always have a location, "kafka" tables should always have a port, etc.). 2. As for UnstructuredTable, I think that this -- like another name we considered, PropertyTable -- is a little too strong handed in implying that these tables are always unstructured (even the data? or just the metadata?) whereas that may not always be the case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
