dimas-b commented on code in PR #1172:
URL: https://github.com/apache/polaris/pull/1172#discussion_r1996275649
##########
client/python/polaris/catalog/py.typed:
##########
Review Comment:
Just wondering, is this file added after the move? Why do we need it now?
##########
regtests/run.sh:
##########
@@ -101,6 +101,7 @@ for TEST_FILE in ${TEST_LIST}; do
NUM_FAILURES=$(( NUM_FAILURES + 1 ))
else
loggreen "Test SUCCEEDED: ${TEST_FILE}"
+ NUM_SUCCESSES=$(( NUM_SUCCESSES + 1 ))
Review Comment:
nit: this change is unrelated to the move, it seems, but it makes sense :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
