MonkeyCanCode commented on PR #1172: URL: https://github.com/apache/polaris/pull/1172#issuecomment-2727746419
> > i think we should still support both running python regression tests within docker as well as running outside docker. To do so, we will need to make change in the dockerfile used by regression to match the same layout instead. > > I see, so we need to adjust the layout inside Docker by making this change and updating the relevant parts accordingly. Is that correct? > > ```diff > - COPY ./client/python /home/spark/regtests/client/python > + COPY ./client/python /home/spark/client/python > ``` I was thinking about following layout instead (project directory): ``` WORKDIR /home/spark/polaris ``` Then we can have the same layout as our git layout such as following: ``` /home/spark/polaris/polaris -> CLI entrypoint /home/spark/polaris/client -> CLI client /home/spark/polaris/regrests -> regtests ``` By doing so, no manual change will be needed when running outside docker (as it is matched to our git layout. so all relative reference to files/directory will stay the same). What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
