MonkeyCanCode commented on PR #1172: URL: https://github.com/apache/polaris/pull/1172#issuecomment-2727669806
> I am seeing failed tests when running on my local. Let me check more then get back. So this is fine with running test within docker (CI is using the same for testing thus able to pass), but it is a breaking change for running test outside docker. Here is the reasoning: Within docker, you now have following layout: ``` drwxrwxrwx 1 spark spark 4096 Mar 16 19:35 credentials -rw-rwxrwx 1 spark spark 2694 Mar 16 19:35 docker-compose.yml -rw-rwxrwx 1 spark spark 2197 Mar 16 21:28 Dockerfile drwxrwxrwx 1 spark spark 4096 Mar 16 21:19 output -rwxrwxrwx 1 spark spark 2339 Mar 16 19:35 polaris-reg-test -rwxrwxrwx 1 spark spark 993 Mar 16 21:13 pyspark-setup.sh -rw-rwxrwx 1 spark spark 8247 Mar 16 19:35 README.md -rw-rwxrwx 1 spark spark 804 Mar 16 19:35 requirements.txt -rwxrwxrwx 1 spark spark 6984 Mar 16 21:08 run.sh -rwxrwxrwx 1 spark spark 5515 Mar 16 19:35 run_spark_sql.sh -rwxrwxrwx 1 spark spark 6053 Mar 16 19:48 setup.sh drwxrwxrwx 1 spark spark 4096 Mar 16 19:35 t_cli drwxrwxrwx 1 spark spark 4096 Mar 16 19:35 t_hello_world drwxrwxrwx 1 spark spark 4096 Mar 16 19:35 t_oauth drwxrwxrwx 1 spark spark 4096 Mar 16 19:35 t_pyspark drwxrwxrwx 1 spark spark 4096 Mar 16 19:35 t_spark_sql ``` Where we are running environment setup scripts on the same path as `client` directory (which matched to the previous behavior when `client` directory was under `regtests`). The problem comes when we tried to run this locally without docker as the reference path is no longer valid such as following: ``` ➜ regtests cat ./pyspark-setup.sh | grep 'cd' cd client/python ``` In this case, `pyspark-setup.sh` is expecting there to be a `client` directory within the same directory, but in reality, it is actually one directory above. i think we should still support both running python regression tests within docker as well as running outside docker. To do so, we will need to make change in the dockerfile used by regression to match the same layout instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
