liamzwbao commented on code in PR #1172: URL: https://github.com/apache/polaris/pull/1172#discussion_r2003216565
########## regtests/pyspark-setup.sh: ########## @@ -18,14 +18,14 @@ # under the License. # -if [ ! -d ~/polaris-venv ]; then - python3 -m venv ~/polaris-venv +if [ ! -d ~/polaris/polaris-venv ]; then Review Comment: Yep, for two reasons: 1. I believe it's better to place the venv inside the project rather than outside. 2. Some parts of the project already assume the venv is inside the project, such as [this](https://github.com/apache/polaris/blob/eae31417f6789ecd006cc85bb18ba387c330e289/build-logic/src/main/kotlin/polaris-root.gradle.kts#L59) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
