eric-maynard commented on code in PR #1231:
URL: https://github.com/apache/polaris/pull/1231#discussion_r2013281459
##########
service/common/src/main/java/org/apache/polaris/service/catalog/generic/GenericTableCatalog.java:
##########
@@ -97,10 +101,9 @@ public void createGenericTable(
List<PolarisEntity> catalogPath = resolvedParent.getRawFullPath();
- // TODO we need to filter by type here?
PolarisResolvedPathWrapper resolvedEntities =
resolvedEntityView.getPassthroughResolvedPath(
- tableIdentifier, PolarisEntityType.GENERIC_TABLE,
PolarisEntitySubType.ANY_SUBTYPE);
+ tableIdentifier, PolarisEntityType.TABLE_LIKE,
PolarisEntitySubType.ANY_SUBTYPE);
Review Comment:
What you linked is just a best-effort check; it's possible you'll still get
a persistence error when this kind of conflict occurs. Ultimately that will be
the safest and most scalable check anyway. It can be done within the
transaction where we upsert and it doesn't require O(n^2) checks when we have n
different subtypes of table.
Also, technically you might not have permission to see that the entity with
that name and what its type is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
