eric-maynard commented on code in PR #1286:
URL: https://github.com/apache/polaris/pull/1286#discussion_r2021916147
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##########
@@ -135,6 +135,24 @@ public static <T> T loadConfig(PolarisConfiguration<T>
configuration) {
.getConfiguration(callContext.getPolarisCallContext(), configuration);
}
+ /**
+ * Returns the value of a `PolarisConfiguration` within the given
callContext, or the default if
+ * no callContext is provided.
+ */
+ public static <T> T loadConfig(PolarisConfiguration<T> configuration,
CallContext callContext) {
Review Comment:
I don't think we should add this back, at least without null-safety checks
or anything.
Also, the pattern
```
callContext
.getPolarisCallContext()
.getConfigurationStore()
.getConfiguration(callContext.getPolarisCallContext(),
configuration);
```
Is very widely used throughout the code; refactoring it everywhere seems out
of scope for this PR and I don't see a reason to diverge just for this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
