eric-maynard commented on code in PR #1286:
URL: https://github.com/apache/polaris/pull/1286#discussion_r2021918551
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -652,6 +663,13 @@ public Response getConfig(
PolarisEntity.of(resolvedReferenceCatalog.getEntity()).getPropertiesAsMap();
String prefix = prefixParser.catalogNameToPrefix(realmContext, warehouse);
+
+ // add the generic table endpoints as supported endpoints if generic table
feature is enabled.
+ Set<Endpoint> supportedGenericTableEndpoints =
+
PolarisConfiguration.loadConfig(FeatureConfiguration.ENABLE_GENERIC_TABLES,
callContext)
+ ? GENERIC_TABLE_ENDPOINTS
+ : ImmutableSet.of();
+
return Response.ok(
Review Comment:
We need to wait until #1264 to actually say these are supported, and
furthermore we need to the logic there up to the actual endpoints first. I have
these changes prepared for after #1264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
