gh-yzou commented on code in PR #1286:
URL: https://github.com/apache/polaris/pull/1286#discussion_r2022048111
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -652,6 +663,13 @@ public Response getConfig(
PolarisEntity.of(resolvedReferenceCatalog.getEntity()).getPropertiesAsMap();
String prefix = prefixParser.catalogNameToPrefix(realmContext, warehouse);
+
+ // add the generic table endpoints as supported endpoints if generic table
feature is enabled.
+ Set<Endpoint> supportedGenericTableEndpoints =
+
PolarisConfiguration.loadConfig(FeatureConfiguration.ENABLE_GENERIC_TABLES,
callContext)
+ ? GENERIC_TABLE_ENDPOINTS
+ : ImmutableSet.of();
+
return Response.ok(
Review Comment:
I think that is slightly different, DROP_WITH_PURGE_ENABLED is protection
for a field in the API call, instead of the whole endpoint, even
DROP_WITH_PURGE_ENABLED is false, the DROP_TABLE endpoint is still supported.
Iceberg today doesn't really provide a mechanism for early failing if sub
functionalities of an operation doesn't work, which could potentially be an
improvement to be make, i think that might be the purpose of the capability
proposal in the iceberg community.
However, for our generic table, if the feature flag is off, I view the whole
feature is disabled, and none of the related endpoints can be supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
