eric-maynard commented on code in PR #1356:
URL: https://github.com/apache/polaris/pull/1356#discussion_r2042580145
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -178,20 +178,22 @@ public synchronized Supplier<TransactionalPersistence>
getOrCreateSessionSupplie
@Override
public synchronized StorageCredentialCache getOrCreateStorageCredentialCache(
- RealmContext realmContext) {
+ RealmContext realmContext, PolarisCallContext polarisCallContext) {
Review Comment:
> You can get from PolarisCallContext to RealmContext
Is that true? I think you can get from CallContext to RealmContext, but not
from PolarisCallContext. Personally I would like to unify these in the future
but I want to keep this PR tightly scoped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
