eric-maynard commented on code in PR #1356:
URL: https://github.com/apache/polaris/pull/1356#discussion_r2042581926


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCache.java:
##########
@@ -76,15 +81,22 @@ public EntityCache(@Nonnull PolarisMetaStoreManager 
polarisMetaStoreManager) {
         };
 
     long weigherTarget =
-        
PolarisConfiguration.loadConfig(FeatureConfiguration.ENTITY_CACHE_WEIGHER_TARGET);
+        polarisCallContext

Review Comment:
   > the configuration store needs non-realm-specific config APIs 
   
   Agreed. Notably, this doesn't work as written on main today. So this isn't a 
new problem introduced by the PR.
   
   Having said that, we should fix this and I would be okay fixing this in this 
PR. Do you have a way you'd like to model this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to