collado-mike commented on PR #1523:
URL: https://github.com/apache/polaris/pull/1523#issuecomment-2860923130

   > Introduce per-task transactional leasing in the metastore layer via 
loadTasks(...). This enables fine-grained compensation by allowing tasks to be 
leased and updated one at a time, avoiding the all-or-nothing semantics of bulk 
operations (which is also mentioned in TODO). This is important for retry 
scenarios, where we want to isolate failures and ensure that tasks are 
independently retried without affecting each other.
   
   I don't understand how this PR enables isolation of task failures. This PR 
only reads the tasks from the metastore one at a time, so the only failure 
would be in loading the task. In a transactional database, the `UPDATE ... 
WHERE` statement would only update the task state when the task is not 
currently leased by another client, so I don't see how one or a few tasks would 
fail to be leased while the others succeed.
   
   The PR description sounds like it intends to tackle _task execution_ failure 
- is that right? If so, loading the tasks from the database isn't going to 
solve that problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to