eric-maynard commented on code in PR #1523:
URL: https://github.com/apache/polaris/pull/1523#discussion_r2124516114
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TransactionalMetaStoreManagerImpl.java:
##########
@@ -1985,11 +1983,60 @@ private PolarisEntityResolver
resolveSecurableToRoleGrant(
return new EntitiesResult(loadedTasks);
}
+ private @Nonnull EntitiesResult loadTasksWithIsolatedTxn(
+ @Nonnull PolarisCallContext callCtx,
+ @Nonnull TransactionalPersistence ms,
+ String executorId,
+ int limit) {
+ List<EntitiesResult> entitySuccessResults = new ArrayList<>();
+ final AtomicInteger failedLeaseCount = new AtomicInteger(0);
Review Comment:
Do we actually need `AtomicInteger` here if it's only being used within one
thread?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
