MonkeyCanCode commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2099424673
##########
getting-started/eclipselink/docker-compose.yml:
##########
@@ -82,7 +82,7 @@ services:
--conf, "spark.sql.catalog.quickstart_catalog.type=rest",
--conf,
"spark.sql.catalog.quickstart_catalog.warehouse=quickstart_catalog",
--conf,
"spark.sql.catalog.quickstart_catalog.uri=http://polaris:8181/api/catalog";,
- --conf,
"spark.sql.catalog.quickstart_catalog.credential=${USER_CLIENT_ID}:${USER_CLIENT_SECRET}",
+ --conf,
"spark.sql.catalog.quickstart_catalog.credential=${CLIENT_ID}:${CLIENT_SECRET}",
Review Comment:
But there are couple problem with both existed route as well as the above,
let me share my observations:
On terminal 1, we will run the following:
```
export ASSETS_PATH=$(pwd)/getting-started/assets/
docker compose --env-file getting-started/assets/getting-started.env \
-f getting-started/assets/postgres/docker-compose-postgres.yml \
-f getting-started/eclipselink/docker-compose-bootstrap-db.yml \
-f getting-started/eclipselink/docker-compose.yml up
```
Due to `USER_CLIENT_ID` and `USER_CLIENT_SECRET` are not yet defined at this
stage, the spark-sql will fail due to fail auth (as both will resolve to empty
string). So the container is in stop state.
Now on terminal 2, we do the needed work to bootstrap polaris entities and
have a different principal created and run the following to set values for
environment variables:
```
export USER_CLIENT_ID=xxxxx
export USER_CLIENT_SECRET=xxxx
```
and try to start the failed containers here with current command in the doc:
```
docker compose -f getting-started/eclipselink/docker-compose.yml up -d
```
This will actually crashed the first setup as two docker compose command on
diff terminal/session will create two diff projects and they are trying to bind
to the same ports.
Now to workaround the problem, I added `-p xxx` to specify project so two
commands from diff sessions will be dealing with same resources. However, this
doesn't solve the problem of created container doesn't reload (which back to my
original point where this is not really a regression as it never works before).
To have containers reload the env, we will need to stop/remove the container
then recreate it. By doing so, it will then try to load envs from the client's
terminal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
