adnanhemani commented on code in PR #1610: URL: https://github.com/apache/polaris/pull/1610#discussion_r2096979589
########## site/content/in-dev/unreleased/getting-started/quickstart.md: ########## @@ -36,7 +36,8 @@ cd ~/polaris :polaris-quarkus-admin:assemble --rerun \ -Dquarkus.container-image.tag=postgres-latest \ -Dquarkus.container-image.build=true -docker compose -f getting-started/eclipselink/docker-compose-postgres.yml -f getting-started/eclipselink/docker-compose-bootstrap-db.yml -f getting-started/eclipselink/docker-compose.yml up +export ASSETS_PATH=$(pwd)/getting-started/assets/ Review Comment: Sorry, this comment is in conjunction with the suggestion from the overall comment. We should do the following: 1. Move the export of CLIENT_ID/CLIENT_SECRET to the top of the file - the Docker Compose files will be able to intake the environment variables set in bash. (i.e. keep one reference at the top of the Quickstart page and one at the top of each of the cloud deployment pages) 2. Remove all references to setting the CLIENT_ID/CLIENT_SECRET elsewhere. 3. Add the export ASSETS_PATH to these references to setting CLIENT_ID/CLIENT_SECRET Does this make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
