dimas-b commented on PR #1555: URL: https://github.com/apache/polaris/pull/1555#issuecomment-2902344278
I think it is preferable to delegate all handling of tokens to the Persistence implementations. We can certainly have a generic holder type (e.g. `Token`) to avoid passing those parameters as `String` everywhere and thus add a source of confusion and mistakes. This should also allow for layered token (should we ever have to paginate over derivatives of lower-level paginated lists). Also, I think we should distinguish token data in requests and responses. Requests need to provide two pieces of data: A1) a flag whether pagination is requested; A2) page size hint; A3) previous page token. Responses provide B1) actual page size, B2) next page token. Token A3 is parsed by the same code that produced token B2. B1 may not equal A2. Implementations may limit repose sizes when A1 is `false`. With that, I think the complexity will actually be reduced and specific token details only need to be considered by the places in code that have to take action based on pagination parameters. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
