dimas-b commented on PR #1555: URL: https://github.com/apache/polaris/pull/1555#issuecomment-2902886175
> Turning this page-token into a PageToken actually used to be done with persistence-specific logic, but I refactored that out in response to https://github.com/apache/polaris/pull/1528#discussion_r2078313029 which indeed simplified the code significantly. We can certainly keep the parsing / encoding logic in `polaris-core`. However, the interpretation of tokens (IMHO) should be delegated to the code that actually implements pagination (Persistence). Sorry, if my comments caused confusion :sweat_smile: Here's the pseudo-code that might work, I think: 1. REST API gets string token / page size params and constructs a "PageRequest" without parsing the token (A1, A2, A3). 2. "PageRequest" goes down to the persistence layer, where each impl. parses the token according to what it expects (B2). Persistence calls core code to do the decoding of the page token and uses a specific token class for that. 3. Persistence returns data using core classes to encode the next token (B2). 4. REST API passes the next token to client without interpretation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
