eric-maynard commented on code in PR #1555: URL: https://github.com/apache/polaris/pull/1555#discussion_r2105648142
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/EntityIdPageToken.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.persistence.pagination; + +import java.util.List; +import java.util.Optional; +import org.apache.polaris.core.entity.EntityNameLookupRecord; +import org.apache.polaris.core.entity.PolarisBaseEntity; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class EntityIdPageToken extends PageToken implements HasPageSize { + private static final Logger LOGGER = LoggerFactory.getLogger(EntityIdPageToken.class); + + public static final String PREFIX = "entity-id"; + + /** The minimum ID that could be attached to an entity */ + private static final long MINIMUM_ID = 0; + + /** The entity ID to use to start with. */ + public static final long BASE_ID = MINIMUM_ID - 1; + + private final long entityId; + private final int pageSize; + + public EntityIdPageToken(int pageSize) { + this.entityId = BASE_ID; + this.pageSize = pageSize; + } + + public EntityIdPageToken(long entityId, int pageSize) { + this.entityId = entityId; + this.pageSize = pageSize; + } + + /** + * Build an {@link EntityIdPageToken} from a {@link PageRequest}, or else a {@link + * ReadEverythingPageToken} if the request doesn't require pagination. + */ + public static PageToken fromPageRequest(PageRequest pageRequest) { + if (pageRequest.getPageTokenString().isEmpty()) { + if (pageRequest.getPageSize().isEmpty()) { + return PageToken.readEverything(); Review Comment: Yeah so this is exactly why previously this logic lived in `PageToken` which is the less specific type. We actually could have even _more_ logic here, since `fromLimit` could return you a `PageToken` that limits but doesn't sort, instead of always sorting as we have now. > WDYT about using boolean PageRequest.readEverything() instead? Can you say more about this? We need a way to be able to call `buildPageToken` in the persistence layer and to get back a `PageToken`. In the future, we may also have different methods within a given persistence implementation using different page token types, which is why previously the parsing happened up the call stack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
