eric-maynard commented on code in PR #1555: URL: https://github.com/apache/polaris/pull/1555#discussion_r2105650414
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/PageRequest.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.persistence.pagination; + +import java.util.Optional; + +/** + * A wrapper for pagination information passed in as part of a request. This can potentially be + * translated into a `PageToken` + */ +public class PageRequest { + private final Optional<String> pageTokenStringOpt; + private final Optional<Integer> pageSizeOpt; + + public PageRequest(String pageTokenString, Integer pageSize) { + this.pageTokenStringOpt = Optional.ofNullable(pageTokenString); + this.pageSizeOpt = Optional.ofNullable(pageSize); + } + + public static PageRequest readEverything() { Review Comment: It's used in quite a few places, wdym? We _could_ try to rely on `isPaginationRequested` everywhere but the code currently actually never calls that method. There could be places in the code that have a `PageToken` and not a `PageRequest`, and in that case we'd need `ReadEverythingPageToken`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
