eric-maynard commented on code in PR #1686:
URL: https://github.com/apache/polaris/pull/1686#discussion_r2121949699
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -556,6 +563,51 @@ public boolean hasChildren(
}
}
+ private int loadVersion() {
+ String query = generateVersionQuery();
+ try {
+ List<SchemaVersion> schemaVersion =
+ datasourceOperations.executeSelect(query, new SchemaVersion());
Review Comment:
Because the schema files are simply versioned, I think it makes sense to
record the schema file which was used to create the tables in the metastore
itself. Otherwise, you'd have to do a complex mapping back from capabilities
back to a `schema-v?` file. That said, as we progress with adding capabilities,
I think it make sense to write down somewhere which capabilities become
available in which version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
