eric-maynard commented on code in PR #1686:
URL: https://github.com/apache/polaris/pull/1686#discussion_r2122636477
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -287,4 +287,22 @@ public static void enforceFeatureEnabledOrThrow(
+ "This should only be set to 'true' for tests!")
.defaultValue(false)
.buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<Boolean>
ADD_TRAILING_SLASH_TO_LOCATION =
+ PolarisConfiguration.<Boolean>builder()
+ .key("ADD_TRAILING_SLASH_TO_LOCATION")
+ .catalogConfig("polaris.config.add-trailing-slash-to-location")
+ .description(
+ "When set, the base location for a table or namespace will have
`/` appended to it")
+ .defaultValue(true)
+ .buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<Boolean> OPTIMIZED_SIBLING_CHECK =
Review Comment:
It's a bit more nuanced than that; the previous locations should have been
written with `ADD_TRAILING_SLASH_TO_LOCATION` enabled (or just with trailing
slashes on them) for the optimized check to be correct. Added this to the
description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
