dimas-b commented on code in PR #1884:
URL: https://github.com/apache/polaris/pull/1884#discussion_r2144173102
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -240,7 +242,11 @@ public Response listNamespaces(
@Override
public Response loadNamespaceMetadata(
- String prefix, String namespace, RealmContext realmContext,
SecurityContext securityContext) {
+ String prefix,
+ String namespace,
+ HttpHeaders httpHeaders,
Review Comment:
If `IcebergCatalogAdapter` needs heads in any method, the headers will have
to be injected all the time (via constructor). However, the methods that do not
need the headers will not have to have them in method parameters.
The overhead of this injection is probably negligible because the headers
are processed one way or another for every request anyway.
Using method parameters, on the other hand forces all implementations to
have those parameters if only one of them actually needs the headers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
