dimas-b commented on code in PR #1884:
URL: https://github.com/apache/polaris/pull/1884#discussion_r2144174673
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -240,7 +242,11 @@ public Response listNamespaces(
@Override
public Response loadNamespaceMetadata(
- String prefix, String namespace, RealmContext realmContext,
SecurityContext securityContext) {
+ String prefix,
+ String namespace,
+ HttpHeaders httpHeaders,
Review Comment:
Also, in headers are needed in a class N levels down the call chain, the top
N-1 levels do not need to pass the headers down - injection will happen into
the target object directly (once at level N).
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -240,7 +242,11 @@ public Response listNamespaces(
@Override
public Response loadNamespaceMetadata(
- String prefix, String namespace, RealmContext realmContext,
SecurityContext securityContext) {
+ String prefix,
+ String namespace,
+ HttpHeaders httpHeaders,
Review Comment:
Also, if headers are needed in a class N levels down the call chain, the top
N-1 levels do not need to pass the headers down - injection will happen into
the target object directly (once at level N).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
