eric-maynard commented on PR #1884: URL: https://github.com/apache/polaris/pull/1884#issuecomment-2970902966
> Why not use the specific @HeaderParam? This is discussed in brief in the description, but there are a couple of points here. 1. You may want to add a HeaderParam(s) to the IRC part of the spec, which we try to keep as close to upstream as possible. 2. The Iceberg REST spec supports clients sending custom headers without the OpenAPI spec having to be specific about this. From what I can see, OpenAPI doesn't actually have a way to capture the fact that arbitrary headers can be a valid input and this is just sort of implied. The change in this PR makes our code generation more in line with this apparent implication. 3. Deployments of Polaris may want to alter the behavior of one API without having to diverge from the spec, which should be supported per (2) but is currently not due to the fact that we drop all headers except those called out in a `HeaderParam` during code generation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
