dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159373601
##########
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##########
@@ -170,6 +175,34 @@ public UserSecretsManagerFactory userSecretsManagerFactory(
return
userSecretsManagerFactories.select(Identifier.Literal.of(config.type())).get();
}
+ @Produces
+ @Singleton
+ @Identifier("http-client-s3")
+ public SdkHttpClient sdkHttpClient(S3AccessConfig config) {
+ ApacheHttpClient.Builder httpClient = ApacheHttpClient.builder();
Review Comment:
`ApacheHttpClient` is more capable in general, AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
