singhpk234 commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2162029106
##########
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##########
@@ -170,6 +175,34 @@ public UserSecretsManagerFactory userSecretsManagerFactory(
return
userSecretsManagerFactories.select(Identifier.Literal.of(config.type())).get();
}
+ @Produces
+ @Singleton
+ @Identifier("http-client-s3")
+ public SdkHttpClient sdkHttpClient(S3AccessConfig config) {
Review Comment:
This is practically possible, i think since we don't specify it default
kicks in from http client, TBH i haven't hit in practice as in AWS EMR spark
jobs generally have one endpoint to connect to, but with a long running service
like polaris, i think the possibility being increased, WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
