singhpk234 commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2162025364
##########
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##########
@@ -170,6 +175,34 @@ public UserSecretsManagerFactory userSecretsManagerFactory(
return
userSecretsManagerFactories.select(Identifier.Literal.of(config.type())).get();
}
+ @Produces
+ @Singleton
+ @Identifier("http-client-s3")
+ public SdkHttpClient sdkHttpClient(S3AccessConfig config) {
+ ApacheHttpClient.Builder httpClient = ApacheHttpClient.builder();
Review Comment:
Iceberg supports both, hence coming from there, Its good to have alternative
specially considering how they behave. for example The Apache HTTP connection
will always read the [entire
stream](https://github.com/apache/httpcomponents-core/blob/2135596b1319910d56efb148566ecbbec0884638/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java#L108)
on close, which results in much more data being read than needed. The URL
connection client does not behave this way. for more details :
https://github.com/apache/iceberg/pull/7262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
