eric-maynard commented on code in PR #1931: URL: https://github.com/apache/polaris/pull/1931#discussion_r2167334496
########## runtime/defaults/src/main/resources/application.properties: ########## @@ -112,6 +112,7 @@ polaris.features."ENFORCE_PRINCIPAL_CREDENTIAL_ROTATION_REQUIRED_CHECKING"=false polaris.features."SUPPORTED_CATALOG_STORAGE_TYPES"=["S3","GCS","AZURE"] # polaris.features."ENABLE_CATALOG_FEDERATION"=true polaris.features."SUPPORTED_CATALOG_CONNECTION_TYPES"=["ICEBERG_REST"] +polaris.features."SUPPORTED_FEDERATION_AUTHENTICATION_TYPES"=["OAUTH", "BEARER"] Review Comment: In turn, I followed `SUPPORTED_CATALOG_STORAGE_TYPES` for `SUPPORTED_CATALOG_CONNECTION_TYPES` :) I think the idea is to be uber-explicit about having a "safe" default everywhere by excluding the unsafe options. However for `SUPPORTED_FEDERATION_AUTHENTICATION_TYPES` there is currently no unsafe option. There may be in the future though (NONE?) so keeping it wouldn't be the worst thing in light of that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
