dimas-b commented on code in PR #1931:
URL: https://github.com/apache/polaris/pull/1931#discussion_r2167950470
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -254,12 +255,24 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(true)
.buildFeatureConfiguration();
- public static final FeatureConfiguration<List<String>>
SUPPORTED_CATALOG_CONNECTION_TYPES =
- PolarisConfiguration.<List<String>>builder()
- .key("SUPPORTED_CATALOG_CONNECTION_TYPES")
- .description("The list of supported catalog connection types for
federation")
- .defaultValue(List.of(ConnectionType.ICEBERG_REST.name()))
- .buildFeatureConfiguration();
+ public static final FeatureConfiguration<List<String>>
+ SUPPORTED_EXTERNAL_CATALOG_CONNECTION_TYPES =
+ PolarisConfiguration.<List<String>>builder()
+ .key("SUPPORTED_EXTERNAL_CATALOG_CONNECTION_TYPES")
Review Comment:
The change of config key is technically a breaking change. I'm personally ok
with this, but it has sem. ver. implications per out current policy:
https://polaris.apache.org/in-dev/unreleased/evolution/
Ideally we should support the old name for a while, but I do not think we
have a mechanism for that ATM.
That said, since this PR is mostly about adding
`SUPPORTED_EXTERNAL_CATALOG_AUTHENTICATION_TYPES`, it might be best to the
rename in a separate PR (plus add backward compatibility).
@eric-maynard WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
