poojanilangekar commented on PR #1931: URL: https://github.com/apache/polaris/pull/1931#issuecomment-3005729198
@eric-maynard I think the name `SUPPORTED_CATALOG_AUTHENTICATION_TYPES` is ambiguous. Polaris itself is a catalog, so if we have a configuration called `SUPPORTED_CATALOG_AUTHENTICATION_TYPES`, a user might think of it as the authentication types supported by this catalog (Polaris) instance. The feature configuration is related to federation and I don't see anything wrong in making the name explicitly related to the feature. I think the same goes for `SUPPORTED_CATALOG_CONNECTION_TYPES`. If you are opposed to adding `FEDERATION` in the name, how about we name (and rename) to `SUPPORTED_EXTERNAL_CATALOG_AUTHENTICATION_TYPES` and `SUPPORTED_EXTERNAL_CATALOG_CONNECTION_TYPES` respectively? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
