eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2193911983
##########
polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java:
##########
@@ -34,11 +35,12 @@ public class BehaviorChangeConfiguration<T> extends
PolarisConfiguration<T> {
protected BehaviorChangeConfiguration(
String key,
Review Comment:
It just seems odd that we would support multiple _invalid_ keys but not
multiple _valid_ keys. In my original comment
[here](https://github.com/apache/polaris/pull/1959#discussion_r2173075151) I
wrote:
> Introduce a framework to support multiple config names, with some of them
marked for deprecation, similar to catalogConfigUnsafe
rather than `... with all but one marked for deprecation ...` because I had
this in mind.
I do agree that the situation where you'd have multiple valid configs seems
contrived, but so does the situation where you'd have multiple invalid configs
or really even one invalid config. So if we're overhauling the whole key
system, I think it makes sense to go all the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
