eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2195746067


##########
polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java:
##########
@@ -34,11 +35,12 @@ public class BehaviorChangeConfiguration<T> extends 
PolarisConfiguration<T> {
 
   protected BehaviorChangeConfiguration(
       String key,

Review Comment:
   The key is not a primary key though. There's no RDBMS or KV store storing 
these; they describe entries in a config file. It seems reasonable to expect 
that multiple different entries could be used to configure the same feature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to