XN137 commented on code in PR #2022:
URL: https://github.com/apache/polaris/pull/2022#discussion_r2200248056
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCacheKey.java:
##########
@@ -95,16 +88,13 @@ public Set<String> getAllowedWriteLocations() {
return allowedWriteLocations;
}
- public @Nullable PolarisCallContext getCallContext() {
- return callContext;
- }
-
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
StorageCredentialCacheKey cacheKey = (StorageCredentialCacheKey) o;
- return catalogId == cacheKey.getCatalogId()
+ return Objects.equals(realmId, cacheKey.getRealmId())
Review Comment:
moved this to a separate PR https://github.com/apache/polaris/pull/2029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
