dimas-b commented on code in PR #2022:
URL: https://github.com/apache/polaris/pull/2022#discussion_r2205337536
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java:
##########
@@ -50,13 +50,10 @@ public class StorageCredentialCache {
private static final long CACHE_MAX_NUMBER_OF_ENTRIES = 10_000L;
private final LoadingCache<StorageCredentialCacheKey,
StorageCredentialCacheEntry> cache;
- private final RealmContext realmContext;
private final PolarisConfigurationStore configurationStore;
/** Initialize the creds cache */
- public StorageCredentialCache(
- RealmContext realmContext, PolarisConfigurationStore configurationStore)
{
- this.realmContext = realmContext;
+ public StorageCredentialCache(PolarisConfigurationStore configurationStore) {
this.configurationStore = configurationStore;
cache =
Caffeine.newBuilder()
Review Comment:
InMemoryEntityCache -> +1 to similar refactoring (better control over heap
usage)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
