XN137 commented on code in PR #2022:
URL: https://github.com/apache/polaris/pull/2022#discussion_r2204653713
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java:
##########
@@ -50,13 +50,10 @@ public class StorageCredentialCache {
private static final long CACHE_MAX_NUMBER_OF_ENTRIES = 10_000L;
private final LoadingCache<StorageCredentialCacheKey,
StorageCredentialCacheEntry> cache;
- private final RealmContext realmContext;
private final PolarisConfigurationStore configurationStore;
/** Initialize the creds cache */
- public StorageCredentialCache(
- RealmContext realmContext, PolarisConfigurationStore configurationStore)
{
- this.realmContext = realmContext;
+ public StorageCredentialCache(PolarisConfigurationStore configurationStore) {
this.configurationStore = configurationStore;
cache =
Caffeine.newBuilder()
Review Comment:
i've added a commit for this, is this what you had in mind?
please double check the naming, module and package.
also imo this raises some questions:
a) how should the new cache config relate to
`FeatureConfiguration.STORAGE_CREDENTIAL_CACHE_DURATION_SECONDS` and
`FeatureConfiguration.STORAGE_CREDENTIAL_DURATION_SECONDS` ?
b) what to do with the `InMemoryEntityCache` which seems to deal with a
single realm? (and thus its max size cant be configured at the application
level)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
