jasonf20 commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2290446611
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageAccessProperty.java:
##########
@@ -39,6 +41,18 @@ public enum StorageAccessProperty {
Boolean.class, "s3.path-style-access", "whether to use S3 path style
access", false),
CLIENT_REGION(
String.class, "client.region", "region to configure client for making
requests to AWS"),
+ AWS_REFRESH_CREDENTIALS_ENABLED(
+ Boolean.class,
+ AwsClientProperties.REFRESH_CREDENTIALS_ENABLED,
+ "whether to enable automatic refresh of credentials",
+ true,
Review Comment:
From my understanding of the client code:
1. The `AwsClientFactory` is initialized ahead of time with generic
properties retrieved from the "configuration" endpoint. This doesn't include
specific endpoints for credential refresh per table and/or access keys.
2. Later on when loading the fileIO per table, the base properties +
additional table properties provided from the `List<Credential>` are [added
here](https://github.com/apache/iceberg/blob/2012f661a19e613abec2ef0024d7b340c9620f14/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L450).
For the property to be available in `Credential.config()` down the line this
needs to be set to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
