dimas-b commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2292394906
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -430,16 +438,28 @@ public Response loadTable(
.loadTableIfStale(tableIdentifier, ifNoneMatch, snapshots)
.orElseThrow(() -> new
WebApplicationException(Response.Status.NOT_MODIFIED));
} else {
+ Optional<String> refreshCredentialsEndpoint =
+ getRefreshCredentialsEndpoint(delegationModes, prefix,
tableIdentifier);
response =
catalog
- .loadTableWithAccessDelegationIfStale(tableIdentifier,
ifNoneMatch, snapshots)
+ .loadTableWithAccessDelegationIfStale(
+ tableIdentifier, ifNoneMatch, snapshots,
refreshCredentialsEndpoint)
.orElseThrow(() -> new
WebApplicationException(Response.Status.NOT_MODIFIED));
}
return tryInsertETagHeader(Response.ok(response), response,
namespace, table).build();
});
}
+ private static Optional<String> getRefreshCredentialsEndpoint(
+ EnumSet<AccessDelegationMode> delegationModes,
+ String prefix,
+ TableIdentifier tableIdentifier) {
+ return delegationModes.contains(AccessDelegationMode.VENDED_CREDENTIALS)
Review Comment:
https://lists.apache.org/thread/dvrx5lg36ovo7387pt6dm06wgmswstvc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
