dimas-b commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2294617443
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/gcp/GcpCredentialsStorageIntegration.java:
##########
@@ -75,7 +75,8 @@ public AccessConfig getSubscopedCreds(
@Nonnull RealmConfig realmConfig,
boolean allowListOperation,
@Nonnull Set<String> allowedReadLocations,
- @Nonnull Set<String> allowedWriteLocations) {
+ @Nonnull Set<String> allowedWriteLocations,
+ String refreshCredentialsEndpoint) {
Review Comment:
It looks like GCP credential refresh _is_ supported:
https://github.com/lakekeeper/lakekeeper/pull/1227/files#diff-8d3c6564c330f473c1e4556b7dbbf79dddae3a49a9d9c55352c7a614fc8b3fb5R88
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
