XJDKC commented on code in PR #2523:
URL: https://github.com/apache/polaris/pull/2523#discussion_r2372833931
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -107,7 +109,7 @@ public static CatalogEntity fromCatalog(RealmConfig
realmConfig, Catalog catalog
return builder.build();
}
- public Catalog asCatalog() {
+ public Catalog asCatalog(ServiceIdentityRegistry serviceIdentityRegistry) {
Map<String, String> internalProperties = getInternalPropertiesAsMap();
Review Comment:
Part 1: transformation isn’t needed. We already discussed this before—I’ll
loop you in as well.
For `asCatalog(ServiceIdentityRegistry serviceIdentityRegistry)`, the
long-term goal is to use `ServiceIdentityRegistry` to inject the service
identity for storage config too.
This new service identity management is meant to be a generic solution for
injecting service identities when accessing any external services. Right now,
there’s no way to inject a service identity for storage config, so users have
to provide the Polaris service identity themselves, which feels odd. With
service identity injection, we can dynamically inject the Polaris service
identity for the catalog entity instead of pulling it from the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
