XJDKC commented on code in PR #2523:
URL: https://github.com/apache/polaris/pull/2523#discussion_r2372838149
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -107,7 +109,7 @@ public static CatalogEntity fromCatalog(RealmConfig
realmConfig, Catalog catalog
return builder.build();
}
- public Catalog asCatalog() {
+ public Catalog asCatalog(ServiceIdentityRegistry serviceIdentityRegistry) {
Map<String, String> internalProperties = getInternalPropertiesAsMap();
Review Comment:
I think keeping `public Catalog asCatalog()` for now makes sense, after we
migrate storage config to this new system, we can remove that one.
But in most of the cases, we don't know the exact catalog type when invoking
this method, will take a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
