flyrain commented on code in PR #2653:
URL: https://github.com/apache/polaris/pull/2653#discussion_r2380626958
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -736,6 +737,9 @@ static int loadSchemaVersion(DatasourceOperations
datasourceOperations) {
return schemaVersion.getFirst().getValue();
} catch (SQLException e) {
LOGGER.error("Failed to load schema version due to {}", e.getMessage(),
e);
+ if (fallbackOnDoesNotExist && e.getMessage().contains("does not exist"))
{
+ return SchemaVersion.MINIMUM.getValue();
+ }
Review Comment:
Since we are sticked with Postgres anyway, for example,
https://github.com/polaris-catalog/polaris/blob/06d523116fd5f5b61f95d8660166e76c00fd2a3e/persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DatasourceOperations.java#L58-L58.
I'm fine with this to be Postgres specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
