eric-maynard commented on code in PR #2653:
URL: https://github.com/apache/polaris/pull/2653#discussion_r2372952819
##########
polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java:
##########
@@ -84,4 +84,14 @@ protected BehaviorChangeConfiguration(
+ " credential vending.")
.defaultValue(false)
.buildBehaviorChangeConfiguration();
+
+ public static final BehaviorChangeConfiguration<Boolean>
SCHEMA_VERSION_FALL_BACK_ON_DNE =
+ PolarisConfiguration.<Boolean>builder()
+ .key("SCHEMA_VERSION_FALL_BACK_ON_DNE")
Review Comment:
This feels similar to letting you break glass and force your own schema
version, which not the intent here (and can be done by manipulating the VERSION
table anyway). Really all we want to do is just capture the fact that the lack
of a version table is implicitly version 0. The flag is only added out of an
abundance of caution and out of recognition of the fact that the error handling
is only best-effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
